fix(browser): Ignore unrealistically long INP values #16484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdkhan14
approved these changes
Jun 4, 2025
size-limit report 📦
|
s1gr1d
approved these changes
Jun 5, 2025
| @@ -22,6 +23,11 @@ import { getBrowserPerformanceAPI, msToSec, startStandaloneWebVitalSpan } from ' | |||
| const LAST_INTERACTIONS: number[] = []; | |||
| const INTERACTIONS_SPAN_MAP = new Map<number, Span>(); | |||
|
|
|||
| /** | |||
| * 60 seconds is the maximum for a plausible INP value | |||
| * (source: Me) | |||
There was a problem hiding this comment.
😂
I hope the git blame stays with your name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't send values INP spans if the reported value is unrealistically long. I decided to draw the line at 60 seconds for now but if anyone has concerns or wants a different upper bound, happy to change it.
Adding this check after receiving reports of hour-long INP spans.
Added some unit tests to test this.